Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Manually backport #4025 #4027

Conversation

christiangnrd
Copy link
Contributor

I'm investigating. Seems like appending : to JULIA_DEPOT_PATH hides the bug.

@IanButterworth
Copy link
Member

Pkg is in the sysimage on 1.10. Using the development version is more complicated.. I might suggest backporting this without tests 🙈

@christiangnrd
Copy link
Contributor Author

Pkg is in the sysimage on 1.10. Using the development version is more complicated.. I might suggest backporting this without tests 🙈

Hahaha after the amount of fixes it took me to get the main PR test right, that's a terrifying proposition.

The test should be valid now.

@christiangnrd
Copy link
Contributor Author

Luckily the test fails even with the : on master so I didn't just add a minute to the 1.12 Pkg test suite 😅.

I think I should remove the test here. Now that I think about it, recompiling the whole library just to test a bug so obscure it's been in the language for 4.5 years might not be worth it.

Lmk what you think.

@christiangnrd christiangnrd changed the base branch from release-1.10 to backports-release-1.10 October 4, 2024 19:53
@IanButterworth
Copy link
Member

Thanks!

@IanButterworth IanButterworth merged commit 82dc94e into JuliaLang:backports-release-1.10 Oct 4, 2024
@christiangnrd christiangnrd deleted the fix55850backport branch October 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants