-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Statistics as an upgradable stdlib #3587
Conversation
Failures look scary, I'm not sure how this PR can have generated these... :-/ |
Error is still there. The explanation is probably this: building project should fix version of deps: Error During Test at /home/runner/work/Pkg.jl/Pkg.jl/test/pkg.jl:685
Got exception outside of a @test
Could not find either `git-tree-sha1` or `path` for package Statistics
Stacktrace:
[1] pkgerror(msg::String)
@ Pkg.Types ~/work/Pkg.jl/Pkg.jl/src/Types.jl:70
[2] build_versions(ctx::Pkg.Types.Context, uuids::Set{Base.UUID}; verbose::Bool)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1071
[3] build_versions
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1051 [inlined]
[4] build(ctx::Pkg.Types.Context, uuids::Set{Base.UUID}, verbose::Bool)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:993
[5] build(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; verbose::Bool, kwargs::@Kwargs{io::Base.BufferStream})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:1056
[6] build(pkgs::Vector{Pkg.Types.PackageSpec}; io::Base.BufferStream, kwargs::@Kwargs{})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:159
[7] build(pkgs::Vector{Pkg.Types.PackageSpec})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:148
[8] build(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::@Kwargs{})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:174
[9] build
@ Main.PkgTestsOuter.PkgTestsInner.OperationsTest ~/work/Pkg.jl/Pkg.jl/src/API.jl:165 [inlined]
[10] (::Main.PkgTestsOuter.PkgTestsInner.OperationsTest.var"#90#91")(project_path::String)
@ Main.PkgTestsOuter.PkgTestsInner.OperationsTest ~/work/Pkg.jl/Pkg.jl/test/pkg.jl:689
[11] (::Main.PkgTestsOuter.PkgTestsInner.Utils.var"#18#19"{Bool, Main.PkgTestsOuter.PkgTestsInner.OperationsTest.var"#90#91"})()
@ Main.PkgTestsOuter.PkgTestsInner.Utils ~/work/Pkg.jl/Pkg.jl/test/utils.jl:149
[12] withenv(::Main.PkgTestsOuter.PkgTestsInner.Utils.var"#18#19"{Bool, Main.PkgTestsOuter.PkgTestsInner.OperationsTest.var"#90#91"}, ::Pair{String, Nothing}, ::Vararg{Pair{String, Nothing}})
@ Base ./env.jl:239
[13] temp_pkg_dir(fn::Main.PkgTestsOuter.PkgTestsInner.OperationsTest.var"#90#91"; rm::Bool, linked_reg::Bool)
@ Main.PkgTestsOuter.PkgTestsInner.Utils ~/work/Pkg.jl/Pkg.jl/test/utils.jl:141
[14] temp_pkg_dir(fn::Function)
@ Main.PkgTestsOuter.PkgTestsInner.Utils ~/work/Pkg.jl/Pkg.jl/test/utils.jl:122
[15] macro expansion
@ ~/work/Pkg.jl/Pkg.jl/test/pkg.jl:686 [inlined]
[16] macro expansion
@ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1599 [inlined]
[17] top-level scope
@ ~/work/Pkg.jl/Pkg.jl/test/pkg.jl:686
[18] include(mod::Module, _path::String)
@ Base ./Base.jl:494
[19] include
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:10 [inlined]
[20] macro expansion
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:90 [inlined]
[21] macro expansion
@ Main.PkgTestsOuter.PkgTestsInner /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1691 [inlined]
[22] macro expansion
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:70 [inlined]
[23] macro expansion
@ Main.PkgTestsOuter.PkgTestsInner /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1599 [inlined]
[24] (::Main.PkgTestsOuter.PkgTestsInner.var"#1#2")()
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:69
[25] with_logstate(f::Function, logstate::Any)
@ Base.CoreLogging ./logging.jl:515
[26] with_logger(f::Function, logger::Base.CoreLogging.NullLogger)
@ Base.CoreLogging ./logging.jl:627
[27] top-level scope
@ ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:67
[28] include(fname::String)
@ Base.MainInclude ./client.jl:489
[29] top-level scope
@ none:6
[30] eval
@ Core ./boot.jl:383 [inlined]
[31] exec_options(opts::Base.JLOptions)
@ Base ./client.jl:290
[32] _start()
@ Base ./client.jl:552 |
So the problem happens when build test package at test/test_packages/BuildProjectFixedDeps, which indeed has Statistics in its Manifest. I've added a commit to insert the git SHA for Statistics 1.11 there. But that means all Manifests will have to be updated. Is that OK? AFAICT this has been the case for DelimitedFiles too, just it wasn't a dependency in tests. Now there's another failure which is surprising given that Statistics is in the registry: DirectDepWithoutCompatEntry: Error During Test at /home/runner/work/Pkg.jl/Pkg.jl/test/force_latest_compatible_version.jl:253
Got exception outside of a @test
cannot find name corresponding to UUID 10745b16-79ce-11e8-11f9-7d13ad32a3b2 in a registry
Stacktrace:
[1] pkgerror(msg::String)
@ Pkg.Types ~/work/Pkg.jl/Pkg.jl/src/Types.jl:70
[2] deps_graph(env::Pkg.Types.EnvCache, registries::Vector{Pkg.Registry.RegistryInstance}, uuid_to_name::Dict{Base.UUID, String}, reqs::Dict{Base.UUID, Pkg.Versions.VersionSpec}, fixed::Dict{Base.UUID, Pkg.Resolve.Fixed}, julia_version::VersionNumber, installed_only::Bool)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:576
[3] resolve_versions!(env::Pkg.Types.EnvCache, registries::Vector{Pkg.Registry.RegistryInstance}, pkgs::Vector{Pkg.Types.PackageSpec}, julia_version::VersionNumber, installed_only::Bool)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:404
[4] up(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}, level::Pkg.Types.UpgradeLevel; skip_writing_project::Bool, preserve::Nothing)
@ Pkg.Operations ~/work/Pkg.jl/Pkg.jl/src/Operations.jl:1536
[5] up(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; level::Pkg.Types.UpgradeLevel, mode::Pkg.Types.PackageMode, preserve::Nothing, update_registry::Bool, skip_writing_project::Bool, kwargs::@Kwargs{})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:351
[6] up
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:326 [inlined]
[7] up
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:164 [inlined]
[8] instantiate(ctx::Pkg.Types.Context; manifest::Nothing, update_registry::Bool, verbose::Bool, platform::Base.BinaryPlatforms.Platform, allow_build::Bool, allow_autoprecomp::Bool, kwargs::@Kwargs{})
@ Pkg.API ~/work/Pkg.jl/Pkg.jl/src/API.jl:1755
[9] instantiate
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:70 [inlined]
[35] macro expansion
@ Main.PkgTestsOuter.PkgTestsInner /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1599 [inlined]
[36] (::Main.PkgTestsOuter.PkgTestsInner.var"#1#2")()
@ Main.PkgTestsOuter.PkgTestsInner ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:69
[37] with_logstate(f::Function, logstate::Any)
@ Base.CoreLogging ./logging.jl:515
[38] with_logger(f::Function, logger::Base.CoreLogging.NullLogger)
@ Base.CoreLogging ./logging.jl:627
[39] top-level scope
@ ~/work/Pkg.jl/Pkg.jl/test/runtests.jl:67
[40] include(fname::String)
@ Base.MainInclude ./client.jl:489
[41] top-level scope
@ none:6
[42] eval
@ Core ./boot.jl:383 [inlined]
[43] exec_options(opts::Base.JLOptions)
@ Base ./client.jl:290
[44] _start()
@ Base ./client.jl:552 |
OK, I've fixed all CI failures. Let me know if the changes look correct. |
@KristofferC Good to go? |
Part of JuliaLang/julia#46501. Blocked by JuliaRegistries/General#89713.