[BinaryPlatforms]: fix triplet breakage #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We momentarily broke the MacOS (and FreeBSD, although I'm not sure that was actually noticed ;P) ecosystem by changing slightly the rules around `triplet(::Platform)`. `Base.BinaryPlatforms` keeps track of the `os_version` and appends it to the end of the triplet for `MacOS` and `FreeBSD`, but on older versions of julia they are always expected to be `14` and `11.1`, respectively. This PR maintains that willful ignorance when an old package calls `Pkg.BinaryPlatforms.triplet()`, but for new packages that are ready to wake up and stop living in a simulation, they can use `Base.BinaryPlatforms.triplet()` to get the full, glorious, properly-versioned triplet string.
staticfloat
force-pushed
the
sf/fix_triplet_breakage
branch
from
83d222f to
c97295f
Compare
|
Tests fail on Linux etc |
|
Like a magician, I wave my hands and suddenly it starts working. (It was waiting on a new nightly) The windows nightly itself seems borked, but that's unrelated to this PR. |
|
Coming into this PR ready to merge:
|
KristofferC
reviewed
Sep 25, 2020
appveyor.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| environment: | |||
| APPVEYOR_RDP_PASSWORD: juliadebugging42 | |||
| APPVEYOR_RDP_PASSWORD: juliadebugging42PLEASE | |||
There was a problem hiding this comment.
It's only weird if it doesn't work
staticfloat
force-pushed
the
sf/fix_triplet_breakage
branch
from
db8e1d0 to
c97295f
Compare
|
Alright, I think I figured out the windows issue, PR here: JuliaLang/julia#37758 In the meantime, Kristoffer, I think this PR is ready for your attentions again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We momentarily broke the MacOS (and FreeBSD, although I'm not sure that
was actually noticed ;P) ecosystem by changing slightly the rules around
triplet(::Platform).Base.BinaryPlatformskeeps track of theos_versionand appends it to the end of the triplet forMacOSandFreeBSD, but on older versions of julia they are always expected to be14and11.1, respectively. This PR maintains that willful ignorancewhen an old package calls
Pkg.BinaryPlatforms.triplet(), but for newpackages that are ready to wake up and stop living in a simulation, they
can use
Base.BinaryPlatforms.triplet()to get the full, glorious,properly-versioned triplet string.