Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet more inference/invalidation fixes #1869

Merged
merged 8 commits into from
Jul 1, 2020
Merged

Yet more inference/invalidation fixes #1869

merged 8 commits into from
Jul 1, 2020

Commits on Jun 30, 2020

  1. Eliminate some boxing 

    Workaround for #15276
    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    160efbe View commit details
    Browse the repository at this point in the history

  2. Pre-allocate seen to improve inference in unique(f, itr) 

    JuliaLang/julia#36280 introduced the ability to
pre-allocate the container used to track values of `f.(itr)` in
`unique(f, itr)`. Particularly for containers with `Union` elements,
this circumvents significant inference problems.

Related: JuliaLang/julia#36454
    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    0ebffb9 View commit details
    Browse the repository at this point in the history

  3. Improve inference for Platform

    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9b5e38e View commit details
    Browse the repository at this point in the history

  4. Add more type info 

    This reduces the vulnerability to invalidations.
    @timholy
    timholy committed Jun 30, 2020
    1 Configuration menu
    Copy the full SHA
    2acb2f9 View commit details
    Browse the repository at this point in the history

  5. Avoid calling ==(::Any, ::Nothing) in read_field 

    Avoids a major source of invalidations
    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    d524d0f View commit details
    Browse the repository at this point in the history

  6. Use maximum(itr; init=default)

    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    f92ee57 View commit details
    Browse the repository at this point in the history

  7. Avoid a strange inference limit when broadcasting

    @timholy
    timholy committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    7e0c911 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. - only test on nightly, test without Pkg server as well 

    - CI: build docs on nightly
    @KristofferC
    KristofferC committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    605f488 View commit details
    Browse the repository at this point in the history