Check for "permissions-blindness" before calculating Artifacts git tree hashes #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/permissions_blind_filesystems
branch
from
cc748dd to
ba92a43
Compare
|
Ah, we explicitly run some git tree hash checks, so the |
staticfloat
force-pushed
the
sf/permissions_blind_filesystems
branch
from
1b97a56 to
756f956
Compare
|
What's the status of this? |
staticfloat
force-pushed
the
sf/permissions_blind_filesystems
branch
3 times, most recently
from
e60d1cf to
3f0e1ec
Compare
|
This is good to go; I reverted the change to make use of |
…ee hashes We need this to be more general than just skipping Windows; if we are on Linux but using an NFS share or FAT32 filesystems, (for instance) we can run into the same issues. So we instead probe for the ability to have a sane `chmod()`/`isexecutable()` run, and if that fails, we do not bother to calculate git tree hashes. This should transparently start to calculate the proper git tree hashes on Windows once JuliaLang/julia#33212 is fixed
staticfloat
force-pushed
the
sf/permissions_blind_filesystems
branch
from
3f0e1ec to
bf13028
Compare
|
On further testing, it appears that when we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to be more general than just skipping Windows; if we are on
Linux but using an NFS share or FAT32 filesystems, (for instance) we can
run into the same issues. So we instead probe for the ability to have a
sane
chmod()/isexecutable()run, and if that fails, we do not botherto calculate git tree hashes. This should transparently start to
calculate the proper git tree hashes on Windows once
JuliaLang/julia#33212 is fixed