-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change naming convention of object files to follow what Base Julia does; also, start testing on macOS again (but only Intel macOS) #930
Conversation
For the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really happy to see this issue fixed, thanks a lot, though I truly am baffled by how this fix is supposed to work 😬
Just two small remarks:
- The
ld
warning seems to appear only on macOS platforms, right? Can we maybe add an@info
statement on macOS systems immediately before or after, informing the user that if said warning appears, it is ok to ignore? - The rationale for using the
-o.a
extension is very subtle. It would be imho great to add a small comment that explains why this is necessary (and/or links to this PR).
@gbaraldi What's the status here? We just need to fix the |
Bump @gbaraldi @staticfloat What needs to be done to fix CI here? |
a6a0461
to
a8ab5c9
Compare
This is done now: 9387406 |
Thus, future readers of the source code will understand why we use this naming convention. [Applies suggestions from code review.]
b789c9c
to
71e9274
Compare
Note: I have merged #967 into this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
==========================================
+ Coverage 83.71% 84.56% +0.85%
==========================================
Files 3 3
Lines 823 823
==========================================
+ Hits 689 696 +7
+ Misses 134 127 -7 ☔ View full report in Codecov by Sentry. |
CI is all green. |
Fixes #738
I'm not sure why this makes macos broken, but given that the fix is simple I'm also not going to dig into it.
The tests don't all pass because
fooifier
isn't there for macos, @staticfloat would need to rebuild it or we just switch to another random artifact.It also prints a bunch of
Which was fixed by JuliaLang/julia#51830 but that didn't get backported into 1.10.