Skip to content

handle normal stream EOF (TLS v1.3 feature)#248

Merged
quinnj merged 1 commit intoJuliaLang:masterfrom
vtjnash:jn/handle-v1.3-eof
Jul 30, 2022
Merged

handle normal stream EOF (TLS v1.3 feature)#248
quinnj merged 1 commit intoJuliaLang:masterfrom
vtjnash:jn/handle-v1.3-eof

Conversation

@vtjnash
Copy link
Copy Markdown
Member

@vtjnash vtjnash commented Jul 29, 2022

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2022

Codecov Report

Merging #248 (ef4dc81) into master (dfd1108) will increase coverage by 2.38%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   71.85%   74.23%   +2.38%     
==========================================
  Files          12       12              
  Lines         707      718      +11     
==========================================
+ Hits          508      533      +25     
+ Misses        199      185      -14     
Impacted Files Coverage Δ
src/ssl.jl 73.10% <56.25%> (+6.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@thchr
Copy link
Copy Markdown

thchr commented Jul 29, 2022

This indeed fixes the bug I had in JuliaWeb/HTTP.jl#896. Thanks!

(HTTP.download("https://www.cryst.ehu.es/") still throws a StackOverflowError on this PR - but that seems to happen on earlier versions of MbedTLS as well, so is probably just an HTTP.jl issue)

@vtjnash vtjnash force-pushed the jn/handle-v1.3-eof branch from ef14923 to ef4dc81 Compare July 30, 2022 02:34
Copy link
Copy Markdown
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtjnash; I can also confirm the fix in behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants