-
-
Notifications
You must be signed in to change notification settings - Fork 657
Register new package SpecialFunctions.jl v0.0.1 #7859
Conversation
With the |
@martinholters In user code (not in a package since we don't have conditional dependencies), I guess one could do if VERSION >= v"0.5.0"
using SpecialFunctions
import SpecialFunctions: bessely, ...
end Though that seems like awful practice. However, with that it should work just fine for any Julia version in which the special functions are exported from Base. Packages that need these functions will need a minimum requirement of 0.5 though. I didn't bother verifying/maintaining 0.4 support in the package since this uses the code as defined in Base for 0.6 (pre-removal), which may not be 0.4-compatible. I don't know about version requirements in METADATA once 0.6 is released. That sounds like a question for @tkelman. |
Can't you put that kind of check directly in the package, and re-export the Base functions for 0.4 and 0.5? |
@dpsanders I suppose, though then 0.4 code wouldn't be able to benefit from any enhancements that have been made to the special functions code since 0.4 was released. Just seems like more effort than it's worth to actively support 0.4 at this point. |
Good point. So then could just redefine the special functions that are available in 0.4 and warn the user that they will have a lot of warnings when doing so. Though I agree that it seems reasonable to just drop support for 0.4 now. |
One option we could consider is to tag a SpecialFunctions version requiring |
I maintain that it isn't really worth the effort to maintain a version of this package that supports 0.4. If another package that needs special functions uses 0.4, they can find a way to work that out through branches, tags, or what have you. As a 0.6 release approaches, I've found that dropping 0.4 support is becoming less and less controversial, especially due to other incompatibilities. |
Repository: JuliaMath/SpecialFunctions.jl |
aa9bc2f
to
61a1901
Compare
Just to be clear: I have no problem with SpecialFunctions requiring Julia 0.5. I just wanted to raise awareness and point out a possible solution. If no-one thinks this is a real issue, I'm absolutely fine with leaving this as is. |
We won't know the version number at which these get removed from base until that gets merged, but is the plan to have these extend Base on versions new enough where the Base version would otherwise just throw an error? |
Yes. Once the Base PR is merged, I'll update the package to import and export the Base symbols. In the interim I figured not (im|ex)porting at all was easiest. |
Repository: JuliaMath/SpecialFunctions.jl![Travis Build Status](https://camo.githubusercontent.com/ad5dd7d0348f0d646fdcf91b31216ff685cd6e28da3e0c5469b5d4a78070e74a/68747470733a2f2f6170692e7472617669732d63692e6f72672f4a756c69614d6174682f5370656369616c46756e6374696f6e732e6a6c2e7376673f6272616e63683d76302e302e31)
Release: v0.0.1
Travis:
cc: @ararslan