Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag AWSS3.jl v0.3.4 #13435

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Feb 19, 2018

Repository: samoconnor/AWSS3.jl
Release: v0.3.4
Travis: Travis Build Status
Diff: vs v0.3.3
requires vs v0.3.3:

--- 0.3.3/requires
+++ 0.3.4/requires
@@ -1,6 +1,6 @@
 julia 0.6
-AWSCore 0.3
-HTTP 0.5.4
+AWSCore 0.3.4
+HTTP
 SymDict
 Retry
 XMLDict

cc: @samoconnor

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@kmsquire
Copy link
Member

Just curious, by losing the HTTP.jl version, are you saying that this works with any version of HTTP.jl? Is that actually true?

@samoconnor
Copy link
Contributor

No, its just that I don't want to keep track of the latest HTTP version in all the AWS*.jl packages. The AWSCore.jl package REQUIREs a particular version of HTTP. AWSS3.jl is happy to use whatever version of HTTP is used by AWSCore.jl. In fact, AWSS3.jl currently does this:

using AWSCore.HTTP
import AWSCore.HTTP

So, I guess I could validly remove HTTP from REQUIRE compeltely.
However, doing the using this way is a hang over from when HTTP was vendored in to AWSCore, so I'll probably change that now that I've noticed it.

@kmsquire
Copy link
Member

Got it, thanks for the explanation.

@samoconnor
Copy link
Contributor

@samoconnor
Copy link
Contributor

@andreasnoack, I take it that all the closing and reopening is to pump the CI?
Is there a better way to do things when I need to tag a bunch of packages the all depend one on the next?

@andreasnoack
Copy link
Member

Is there a better way to do things when I need to tag a bunch of packages the all depend one on the next?

Not yet. Unfortunately. We should have a way to detect this and automatically trigger a build when there is a dependency relation between the packages.

@andreasnoack andreasnoack merged commit fbb7b5a into JuliaLang:metadata-v2 Feb 20, 2018
@attobot attobot deleted the AWSS3/v0.3.4 branch February 20, 2018 09:21
@samoconnor
Copy link
Contributor

Perhaps the CI script should merge in all of the currently un-merged attobot PRs so that arbitrary interdependencies don't cause failure?
Reminds me of this: JuliaLang/Juleps#44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants