Avoid crashing on ambiguous tokenization of char vs adjoint #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tokenizer can't really solve this case, it needs help from the parser. ie, tighter coupling of tokenizer and parser. However the workarounds here avoid crashing the parser and even gives the right result in most cases.
Codecov Report
@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 96.47% 96.48%
=======================================
Files 15 15
Lines 3919 3925 +6
=======================================
+ Hits 3781 3787 +6
Misses 138 138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
Eh let's go with this. It's not pretty, but it'll do for now. |
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…g/JuliaSyntax.jl#251) The tokenizer can't really solve this case, it needs help from the parser. ie, tighter coupling of tokenizer and parser. However the workarounds here avoid crashing the parser and even gives the right result in most cases.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…g/JuliaSyntax.jl#251) The tokenizer can't really solve this case, it needs help from the parser. ie, tighter coupling of tokenizer and parser. However the workarounds here avoid crashing the parser and even gives the right result in most cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tokenizer can't really solve this case, it needs help from the parser. ie, tighter coupling of tokenizer and parser.
However the workarounds here avoid crashing the parser and even gives the right result in most cases.
Close #186. Close #25