-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Make macros bind stronger than commas within parentheses #212
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 14 14
Lines 4007 4008 +1
=======================================
+ Hits 3874 3875 +1
Misses 133 133 ☔ View full report in Codecov by Sentry. |
bb5a263
to
244be72
Compare
Also enable it within concatenation syntax for consistency
9863bb4
to
0a0ffa3
Compare
Perhaps it'd make sense to deprecate |
It's "horrible", but evidence suggests that users don't understand the existing precedence and actively write bugs with the existing semantics. Look at the analysis here If we fix more cases in the ecosystem than we break by making this change, is that actually "horrible"? There's no right answer, only tradeoffs. |
As discussed in JuliaLang/julia#36547
That is,
f(@x a, b)
parses asrather than
Unfortunately, this is mildly breaking, due to such strange syntax as
(@unpack a,b = c)