seed explicitly MersenneTwister(0) #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Apr 2, 2017
src/init.jl
Outdated
| @@ -4,7 +4,7 @@ include(depfile) # generated by Pkg.build("IJulia") | |||
|
|
|||
| # use our own random seed for msg_id so that we | |||
| # don't alter the user-visible random state (issue #336) | |||
| const IJulia_RNG = MersenneTwister() | |||
| const IJulia_RNG = MersenneTwister(0) | |||
There was a problem hiding this comment.
I think we want srand(MersenneTwister(0))
There was a problem hiding this comment.
IIUC, you added this IJulia_RNG as a replacement to GLOBAL_RNG in uuid4 to solve an issue, so indeed it seems that it should be randomly seeded as GLOBAL_RNG is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default constructor
MersenneTwister()will be deprecated, cf. JuliaLang/julia#16984 (comment).