Skip to content

Simplify lock(DOWNLOAD_LOCK) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefanKarpinski merged 4 commits into from
May 17, 2022
+5 −6
Merged

Simplify lock(DOWNLOAD_LOCK) #136

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d594634
Simplify lock(DOWNLOAD_LOCK)
tkf Aug 7, 2021
09c7599
Move yield back inside the lock
tkf Aug 8, 2021
82d0abb
Merge branch 'master' into simplify-lock
StefanKarpinski May 16, 2022
3df806b
Update src/Downloads.jl
StefanKarpinski May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Downloads.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,13 @@ function request(
throw :: Bool = true,
downloader :: Union{Downloader, Nothing} = nothing,
) :: Union{Response, RequestError}
lock(DOWNLOAD_LOCK) do
yield() # let other downloads finish
downloader isa Downloader && return
while true
if downloader === nothing
Comment thread
StefanKarpinski marked this conversation as resolved.
lock(DOWNLOAD_LOCK) do
yield() # let other downloads finish
Comment thread
StefanKarpinski marked this conversation as resolved.
Outdated
downloader = DOWNLOADER[]
downloader isa Downloader && return
DOWNLOADER[] = Downloader()
if downloader === nothing
downloader = DOWNLOADER[] = Downloader()
end
end
end
local response
Expand Down