Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Returns #751

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Add Returns #751

merged 1 commit into from
Sep 8, 2021

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Sep 7, 2021

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #751 (4118ac3) into master (d79d0fc) will decrease coverage by 3.11%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
- Coverage   81.99%   78.88%   -3.12%     
==========================================
  Files           4        4              
  Lines         561      592      +31     
==========================================
+ Hits          460      467       +7     
- Misses        101      125      +24     
Impacted Files Coverage Δ
src/Compat.jl 78.90% <87.50%> (-3.12%) ⬇️
src/compatmacro.jl 88.88% <0.00%> (-3.42%) ⬇️
src/iterators.jl 62.50% <0.00%> (-2.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79d0fc...4118ac3. Read the comment docs.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might want to add a test for the explicitly typed constructor, although it appears that is also not tested in base...

@fredrikekre fredrikekre merged commit 6e04e3a into JuliaLang:master Sep 8, 2021
@mcabbott mcabbott deleted the returns branch September 8, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants