Fix 2-arg argmin/argmax/findmin/findmax #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 4 4
Lines 513 513
=======================================
Hits 419 419
Misses 94 94
Continue to review full report at Codecov.
|
|
As discussed in #745 (comment) although the behaviour of Compat.jl is changing this counts as non-breaking as the original behaviour was never officially released. |
|
News entry was missing from the original #738 |
|
As this is a bugfix I've marked it as such. If someone cared to do so this could be backported as 3.26.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #738 to use the changes made to JuliaLang/julia#41076. Fixes #745.