Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

similar(::PermutedDimsArray) #693

Merged
merged 4 commits into from
Apr 30, 2020
Merged

similar(::PermutedDimsArray) #693

merged 4 commits into from
Apr 30, 2020

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Apr 6, 2020 •
edited
Loading

@martinholters martinholters mentioned this pull request Apr 27, 2020
Merged
martinholters
martinholters approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs conflicts to be resolved and should wait for #695 (also with resolving the conflicts). After merging this one, we tag 3.9.0.

martinholters
martinholters reviewed Apr 30, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@martinholters
Copy link
Member

Ok, should be good to go now.

@mcabbott
Copy link
Contributor Author

Thanks for doing the merge, looks good to me.

@martinholters martinholters merged commit 7209cc9 into JuliaLang:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcabbott @martinholters