Handle arrays in rounding functions #45

rened · 2015-02-18T09:38:07Z

In v0.3, only iround is able to deal with arrays when a type is specified:

using Compat
julia> round(Integer,[1.0,2.0])
2-element Array{Int64,1}:
 1
 2
julia> ceil(Integer,[1.0,2.0])
ERROR: `iceil` has no method matching iceil(::Type{Integer}, ::Array{Float64,1})
 in ceil at /Users/rene/.julia/v0.3/Compat/src/Compat.jl:66

This PR defines a new compatibility function for arrays, making the above pass (like in v0.4)

simonster · 2015-03-01T17:26:09Z

Definitely a good idea. Can you add some tests?

rened · 2015-03-02T14:36:24Z

@simonster Added some tests!

simonster · 2015-03-03T22:52:21Z

test/runtests.jl

@@ -67,6 +67,11 @@ if VERSION < v"0.4.0-dev+1387"
 end

 @test round(Int, 3//4) == 1
+for x in [(round, iround), (ceil, iceil), (floor, ifloor), (trunc, itrunc)]
+    for v = Any[1, 1.1, [1,1], [1.1, 1.1], [1 1], [1.1 1.1]]
+        @test @compat x[1](Int,v) == x[2](v)


This shouldn't actually need @compat

rened · 2015-03-04T07:05:27Z

Thanks for your comments, good points of course! Updated.

simonster mentioned this pull request Mar 1, 2015

Did something change with ceil on Julia 0.3.6? JuliaLang/julia#10363

Closed

simonster reviewed Mar 3, 2015
View reviewed changes

handle arrays in rounding functions

12310d1

simonster closed this in 8339923 Mar 29, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle arrays in rounding functions #45

Handle arrays in rounding functions #45

rened commented Feb 18, 2015

simonster commented Mar 1, 2015

rened commented Mar 2, 2015

simonster Mar 3, 2015

rened commented Mar 4, 2015

Handle arrays in rounding functions #45

Handle arrays in rounding functions #45

Conversation

rened commented Feb 18, 2015

simonster commented Mar 1, 2015

rened commented Mar 2, 2015

simonster Mar 3, 2015

Choose a reason for hiding this comment

rened commented Mar 4, 2015