Skip to content

Commit

Permalink
Mark Compat.Base64 from #418 for deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
martinholters committed Oct 8, 2019
1 parent 012edcb commit eb08888
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 17 deletions.
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ Currently, the `@compat` macro supports the following syntaxes:

## Module Aliases

* `using Compat.Base64` is provided on versions older than 0.7, where this library is not
yet a part of the standard library. ([#24361])

* `using Compat.Unicode` is provided on versions older than 0.7, where this library is not
yet a part of the standard library. ([#25021])

Expand Down
8 changes: 1 addition & 7 deletions src/Compat.jl
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,11 @@ import REPL
import Serialization
import Statistics
import Base: Fix2
import Base64


include("compatmacro.jl")

# 0.7.0-DEV.2338
@static if VERSION >= v"0.7.0-DEV.2338"
import Base64
else
import Base.Base64
end

@static if VERSION < v"0.7.0-DEV.2377"
(::Type{Matrix{T}}){T}(s::UniformScaling, dims::Dims{2}) = setindex!(zeros(T, dims), T(s.λ), diagind(dims...))
(::Type{Matrix{T}}){T}(s::UniformScaling, m::Integer, n::Integer) = Matrix{T}(s, Dims((m, n)))
Expand Down
7 changes: 7 additions & 0 deletions test/old.jl
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,13 @@ module TestSerialization
end
end

# 0.7.0-DEV.2338
module Test24361
using Compat
using Compat.Test
@test String(Compat.Base64.base64decode("SGVsbG8h")) == "Hello!"
end


# tests of removed functionality (i.e. justs tests Base)

Expand Down
7 changes: 0 additions & 7 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,6 @@ end
@test get(IOContext(IOBuffer(), :arg1=>true, :arg2=>true, :arg3=>true), :arg3, false)
@test get(IOContext(IOBuffer(), :arg1=>true, :arg2=>true), :arg2, false)

# 0.7.0-DEV.2338
module Test24361
using Compat
using Compat.Test
@test String(Compat.Base64.base64decode("SGVsbG8h")) == "Hello!"
end

# 0.7
let A = [1]
local x = 0
Expand Down

0 comments on commit eb08888

Please sign in to comment.