Drop compat code for chol(::UniformScaling) from #382

JuliaLang · Sep 30, 2019 · 8bb14de · 8bb14de
1 parent 35953ec
commit 8bb14de
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 20 deletions.
diff --git a/src/Compat.jl b/src/Compat.jl
@@ -14,15 +14,6 @@ import Base.invokelatest
 
 include("compatmacro.jl")
 
-# https://github.com/JuliaLang/julia/pull/22633
-if VERSION < v"0.7.0-DEV.1041"
-    # these have been deprecated in Julia 0.7.0-DEV.5272; we keep them here to avoid
-    # breakage in packages already using them on Julia 0.6
-    import Base.LinAlg: chol, chol!
-    chol!(J::UniformScaling, uplo) = UniformScaling(chol!(J.λ, uplo))
-    chol(J::UniformScaling, args...) = UniformScaling(chol(J.λ, args...))
-end
-
 # https://github.com/JuliaLang/julia/pull/21746
 const macros_have_sourceloc = VERSION >= v"0.7-" && length(:(@test).args) == 2
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -67,17 +67,6 @@ for x in (3.1, -17, 3//4, big(111.1), Inf)
     @test minmax(x) == (x, x)
 end
 
-# PR 22633
-if VERSION < v"0.7.0-DEV.5272"
-    # chol(A::UniformScaling) has been deprecated in Julia, we still test it to avoid
-    # accidental breakage in packages using the Compat vesion of it on Julia 0.6
-    for T in (Float64, ComplexF32, BigFloat, Int)
-        λ = T(4)
-        @test chol(λ*I).λ ≈ √λ
-        @test_throws Union{ArgumentError,Compat.LinearAlgebra.PosDefException} chol(-λ*I)
-    end
-end
-
 let
     @compat cr(::CartesianIndices{2}) = 2
     @test cr(CartesianIndices((5, 3))) == 2