CompatHelper: bump compat for "TestImages" to "1.0"

[github-actions]

This pull request changes the compat entry for the TestImages package from 0 to 0, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

[timholy]

Hmm, that segfault is concerning. Did constraining the minor version on FileIO fix the problem locally?

When I try to build the docs locally I get this:

julia> include("make.jl")
ERROR: LoadError: ArgumentError: page root should be a valid dir, instead it's docs/examples
Stacktrace:
 [1] DemoCards.DemoPage(::String) at /home/tim/.julia/packages/DemoCards/RMvSf/src/types/page.jl:94
 [2] #makedemos#62(::String, ::String, ::String, ::String, ::String, ::Bool, ::typeof(makedemos), ::String) at /home/tim/.julia/packages/DemoCards/RMvSf/src/generate.jl:86
 [3] (::DemoCards.var"#kw##makedemos")(::NamedTuple{(:branch,),Tuple{String}}, ::typeof(makedemos), ::String) at ./none:0
 [4] top-level scope at /home/tim/src/juliaimages.github.io/docs/make.jl:7
 [5] include at ./boot.jl:328 [inlined]
 [6] include_relative(::Module, ::String) at ./loading.jl:1105
 [7] include(::Module, ::String) at ./Base.jl:31
 [8] include(::String) at ./client.jl:424
 [9] top-level scope at REPL[4]:1
in expression starting at /home/tim/src/juliaimages.github.io/docs/make.jl:7

Since you're the DemoCards expert, any suggestions?

[johnnychen94]

The error is caused by testimage("mandrill"). The only package version difference related to TestImages between this build and last successful build is FileIO v1.1, so I want to check if this is the cause. (I can get a successful build locally on both versions without segfault -- OS: Windows)

-- Update

Okay I think this is caused by FileIO v1.2 😂 although JuliaIO/FileIO.jl#243 looks normal to me.

When I try to build the docs locally I get this

This isn't related to the segment fault, you can successfully build that with include("docs/make.jl") in the project root folder. I didn't consider the case include("make.jl") when I write DemoCards.

[timholy]

Good to know, and very nice that you figured it out so quickly.

Of course, the fact that this fixes it is actually quite concerning. Since it seems to only happen on Travis, that both makes it less of a problem and also much harder to debug.

[johnnychen94]

FYI, in DemoCards's docs there's a testimage("lena_color_256"), and this issue doesn't happen in Github Action

Links:

• Github Action log
• similar doc code

[timholy]

Instead of restricting the version of FileIO, I suppose another option would be to build the docs on Julia 1.3. Shall we try that and see what happens?

[johnnychen94]

Perhaps retrigger the build on JuliaImages/TestImages.jl@3102f04 first? The current pass build of that is with FileIO v1.1. I don't have permission to test that.

Upgrading versions can be an easy path, but I still want to make the whole documentation based on Julia 1.0 and add version notes for cases that require higher versions (just like the julia docs do).

I prefer to hold this PR and retrigger the build for a while, just to keep sure it's not some random failure from travis.

[timholy]

https://travis-ci.org/JuliaImages/TestImages.jl/builds/622358737?utm_source=github_status&utm_medium=notification

[johnnychen94]

Here's how demos run in DemoCards and Literate: https://github.com/johnnychen94/DemoCards.jl/blob/407d8662d060703ddca0353a9df6f969c8be1663/src/types/julia.jl#L109-L114

I'm not familiar with Julia's internal mechanism, will that include be a possible cause?

Update --

The new round of debug says it's not due to DemoCards

[johnnychen94]

I thought it's caused by @nospecialize in JuliaIO/FileIO.jl#243, but the build in a modified FileIO branch without that still fails. 😕 (Actually it succeed once, but then continued to throw segfault when I tried to rebuild it) travis log

Compared to use Julia 1.3.0, I prefer to limit the FileIO version to v1.1.0 until it's fixed, so I'm going to revert this PR to the FileIO v1.1.0 status.

[johnnychen94]

@timholy Looks like this issue isn't a random CI issue, so there's little I can do for now. May I merge this just to not hinder the future builds?

[johnnychen94]

FYI, the DemoCards path issue #98 (comment) is now fixed JuliaDocs/DemoCards.jl@f7fb503