Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reparamterization of CartesianRange on 0.7 #34

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 13, 2017

Doesn't pass tests on 0.7, but that wasn't really my goal here. Fixes JuliaImages/Images.jl#653.

@timholy
Copy link
Member Author

timholy commented Jul 13, 2017

(Well, there's a later failure in ImageFiltering due to JuliaMath/FFTW.jl#13, so this won't really get Images even building let alone passing.)

@timholy
Copy link
Member Author

timholy commented Jul 13, 2017

Or we could wait for JuliaLang/Compat.jl#377

@codecov
Copy link

codecov bot commented Jul 13, 2017

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files           7        7           
  Lines         267      267           
=======================================
  Hits          262      262           
  Misses          5        5
Impacted Files Coverage Δ
src/resizing.jl 98.54% <ø> (ø) ⬆️
src/autorange.jl 93.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6ee0a...1f4e987. Read the comment docs.

@timholy timholy merged commit 2357271 into master Aug 6, 2017
@timholy timholy deleted the teh/0.7 branch August 6, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants