Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not modify original image in in-place resizing #151

Merged
merged 10 commits into from
Oct 28, 2021
Merged

Conversation

pxl-th
Copy link
Collaborator

@pxl-th pxl-th commented Oct 28, 2021

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #151 (c65c7d1) into master (6f2a65a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files           8        8           
  Lines         216      216           
=======================================
  Hits          195      195           
  Misses         21       21           
Impacted Files Coverage Δ
src/resizing.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2a65a...c65c7d1. Read the comment docs.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for catching and fixing this!

There's a CHANGELOG.md used to track note-worthy changes. You can optionally add a bug-fix entry there and then I think we can release v0.9.3.

@pxl-th since you get the superpower already, I'll leave it to you to merge and release. The commit history is kind of random so let's squash and merge.

@pxl-th
Copy link
Collaborator Author

pxl-th commented Oct 28, 2021

The commit history is kind of random so let's squash and merge.

Yeah, forgot to pull changes before starting to work on this :)

@pxl-th pxl-th merged commit e8f4bc5 into master Oct 28, 2021
@pxl-th pxl-th deleted the fix-inplace-resizing branch October 28, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants