Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type instability of restrict #124

Merged
merged 1 commit into from
May 20, 2021
Merged

fix type instability of restrict #124

merged 1 commit into from
May 20, 2021

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented May 20, 2021

There're two type instabilities come up in the recent upstream update:

  • The first is due to similar improvement on OffsetArray (new type instability during restrict on OffsetArray #118) and nicely fixed with the patch provided by @jishnub
  • The second is due to the recent (I believe) Colors update (the root is not identified). This is fixed by rewriting the raestrict_eltype implementation without doing runtime calculation (as possible as we can).

closes #118

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #124 (28e612f) into master (a476cee) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   94.76%   95.02%   +0.26%     
==========================================
  Files           7        7              
  Lines         363      362       -1     
==========================================
  Hits          344      344              
+ Misses         19       18       -1     
Impacted Files Coverage Δ
src/resizing.jl 98.78% <100.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a476cee...28e612f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new type instability during restrict on OffsetArray
1 participant