Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite for julia 0.7 #52

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Rewrite for julia 0.7 #52

merged 3 commits into from
Jul 13, 2018

Commits on Jul 3, 2018

  1. Rewrite for julia 0.7

    The strategy used here for ColorView and ChannelView has been
    implemented in a much more general way for ReinterpretArray. It makes
    sense to leverage the Base implementation. Plus, now that
    `reinterpret` is no longer restricted to `Array`, it turns out that we
    run into certain dispatch problems that stem from changing the
    dimensionality to handle/subsume color channels. The solution here is
    to introduce a `reinterpretc` that is specifically for handling
    colors.
    
    This definitely breaks old code.
    timholy committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    4999ce3 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. colorview(RGB, grays...) uses mappedarray instead of StackedView

    This should be more performant, and now that we have a generic
    `reinterpret` we can cope with the consequences.
    timholy committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    81907af View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2018

  1. Rework for reinterpret with offset axes

    The final version of support for reinterpreting arrays with offset
    axes requires that the first axis starts with 1. Consequently we now
    reshape before we reinterpret. This led to a surprising number of
    cascading changes.
    
    Also fixes the Base._length deprecation.
    timholy committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    20fb5b5 View commit details
    Browse the repository at this point in the history