Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinearStretching enhancements #28

Merged
merged 14 commits into from
Mar 27, 2020
Merged

LinearStretching enhancements #28

merged 14 commits into from
Mar 27, 2020

Commits on Mar 21, 2020

  1. LinearStretching enhancements 

    * expose src_minval and src_maxval of LinearStretching ( issue #27)
* performance tweak by
  * avoiding recomputation in inner loop
  * early return for trivial case
* clamp values to (minval, maxval)
    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    2c24cb6 View commit details
    Browse the repository at this point in the history

  2. ImageContrastAdjustment v0.3.5

    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    35f1d5a View commit details
    Browse the repository at this point in the history

  3. more tweaks

    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    01120d0 View commit details
    Browse the repository at this point in the history

  4. check LinearStretching parameters at construction

    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    20fcaf8 View commit details
    Browse the repository at this point in the history

  5. add convinient constructors for LinearStretching 

    * LinearStretching((0.1, 0.8)=>(0.2, 0.9))
* LinearStretching(nothing=>(0.2, 0.9))
* LinearStretching((0.1, 0.8))
    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    5674568 View commit details
    Browse the repository at this point in the history

  6. deprecate (minval, maxval) in favor of (dest_minval, dest_maxval) 

    Although two new fields are introduced to LinearStretching, it doesn't
hurt the general performance; the construction time is about 3ns
    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    a198016 View commit details
    Browse the repository at this point in the history

  7. fix Gray{Float32} performance regression

    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    47b127b View commit details
    Browse the repository at this point in the history

  8. the "last" performance tweak

    @johnnychen94
    johnnychen94 committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    65c7c22 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. rename dest_ to dst_

    @johnnychen94
    johnnychen94 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    a703029 View commit details
    Browse the repository at this point in the history

  2. use LinearStretching((src_minval, src_maxval)=>nothing) notation

    @johnnychen94
    johnnychen94 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    b3dc554 View commit details
    Browse the repository at this point in the history

  3. clean up performance tweaks and comments

    @johnnychen94
    johnnychen94 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    bd233aa View commit details
    Browse the repository at this point in the history

  4. correct the constructor signature 

    cont. b3dc554
    @johnnychen94
    johnnychen94 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6c1de26 View commit details
    Browse the repository at this point in the history

  5. do clamp after linear stretching instead of before 

    although clamp before linear stretching is slightly faster, it has
boundary rounding issues, which causes test failures and isn't reliable
to use
    @johnnychen94
    johnnychen94 committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6197f25 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2020

  1. expose no_clamp option to the constructor

    @johnnychen94
    johnnychen94 committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    a254af4 View commit details
    Browse the repository at this point in the history