Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: implement varmult_finite #26

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

johnnychen94
Copy link
Member

The implementation is more delicate than I thought it is; it is not very clean and there might be a lot of type-related issues in the current implementation.

I choose to keep the varfinite symbol as it's more convenient to use, if you think we should deprecate it then I can remove it.

Todo:

  • check the type stability
  • tests are needed

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #26 (c59bc9b) into master (5687005) will decrease coverage by 0.47%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   92.07%   91.60%   -0.48%     
==========================================
  Files           5        5              
  Lines         227      250      +23     
==========================================
+ Hits          209      229      +20     
- Misses         18       21       +3     
Impacted Files Coverage Δ
src/utils.jl 90.90% <66.66%> (-9.10%) ⬇️
src/statistics.jl 85.41% <93.33%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5687005...c59bc9b. Read the comment docs.

@johnnychen94 johnnychen94 marked this pull request as draft October 19, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant