Change DOS date from 0x0000 to 0x0021 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 99.61% 99.61% -0.01%
==========================================
Files 6 6
Lines 773 772 -1
==========================================
- Hits 770 769 -1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
nhz2
commented
Apr 11, 2024
test/test_writer.jl
Outdated
| @@ -121,6 +123,62 @@ include("external_unzippers.jl") | |||
| end | |||
| end | |||
|
|
|||
| @testset "Writer compat with ZipStreams" begin | |||
| # setup test env for ZipStreams | |||
There was a problem hiding this comment.
ZipStreams needs an old version of TranscodingStreams, so I'm using Malt to run it in an isolated environment.
nhz2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Zip archives created with this package to be read by
ZipStreams.jlThis also matches the dos date used by Info-Zip when run with the
-Xflag and 7zip when run with the-mtm-flag.This date is "1980-01-01", the previous date was the invalid "1980-00-00"