-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows file modes: turn executable bits off for plain fails #83
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
+ Coverage 95.68% 96.37% +0.69%
==========================================
Files 4 4
Lines 579 635 +56
==========================================
+ Hits 554 612 +58
+ Misses 25 23 -2
Continue to review full report at Codecov.
|
So far, so good. Still need to try this in the problematic combination. |
Unbekownst to me, Windows defaults to files being executable, so we were incorrectly extracting normal files as executables. We didn't detect this because until JuliaLang/julia#35625 we were blind to the executable bit on Windows. With that change, however, we can now tell that we are incorrectly leaving normal files executable. JuliaLang/Pkg.jl#2253 fixes Pkg's GitTools.tree_hash and in the process breaks our tests since they now correctly detect that we are extracting non-executable files incorrectly on Windows. This PR fixes that, making tests pass again with that fix.
ba56b07
to
a0f56ee
Compare
As I suspect (and I'm impressed that the tests caught this!), the permission copy needed to be recursive, so I implemented that. There was another failure with this fix on Windows nightly which was a bit of a catch-22: since we were using |
…uliaIO#83)" This reverts commit 1b63f2a.
Unbekownst to me, Windows defaults to files being executable, so we were incorrectly extracting normal files as executables. We didn't detect this because until JuliaLang/julia#35625 we were blind to the executable bit on Windows. With that change, however, we can now tell that we are incorrectly leaving normal files executable. JuliaLang/Pkg.jl#2253 fixes Pkg's GitTools.tree_hash and in the process breaks our tests since they now correctly detect that we are extracting non-executable files incorrectly on Windows. This PR fixes that, making tests pass again with that fix. Failure observed in JuliaLang/julia#38678.