Check whether ColorView is defined #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColorView has been deprecated since Nov 2017, but only as a constructor. Hence direct uses of the type did not get noticed. I may "resurrect" `ColorView` in new form, and if so the existing definition here should still work, but in case we go through a period where there is no `ColorView` we should check for its existence.
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 73.61% 72.91% -0.70%
==========================================
Files 1 1
Lines 288 288
==========================================
- Hits 212 210 -2
- Misses 76 78 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColorView has been deprecated since Nov 2017, but only as a constructor. Hence direct uses of the type did not get noticed. I may "resurrect"
ColorViewin new form, and if so the existing definition hereshould still workmight work in limited cases, but in case we go through a period where there is noColorViewwe should check for its existence.xref JuliaIO/ImageMagick.jl#185. Would be good to get a new release out pronto since I expect ColorView will either disappear or change implementation within the next couple of months, and best to get this disseminated first.