Fix how properties are passed during dataset creation #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is also the fix for the problem mentioned in #141 (comment). |
JuliaIO/HDF5.jl#631 fixed a method ambiguity that is recognized in Julia v1.3+, but the fix caused the usage here to break. This fixes the situation on HDF5.jl v0.13.4+.
|
A new HDF5.jl v0.13.6 has been tagged which introduces a deprecation for the method that #141 fixes, and this PR is the remaining fix necessary due to an ambiguity fix in HDF5's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaIO/HDF5.jl#631 fixed a method ambiguity that is recognized in Julia v1.3+, but the fix caused the usage here to break. This duplicates the property creation/passing method used in the next
m_writearraymethod.Note that there are other breaking changes on recent HDF5.jl, which will require a pending PR (JuliaIO/HDF5.jl#655) to add in backwards-compatibility deprecations.