Fix JSON.parse with dicttype specified #137
Conversation
|
@maartenheremans, can you clarify the issue that this is addressing, and add a test if needed? |
|
@kmsquire The problem is that JSON.parse is supposed to be able to accept a dicttype parameter, however, it doesn't work if you want to specify, for example, |
| @@ -245,7 +246,8 @@ end | |||
| @test sprint(JSON.print, [Inf]) == "[null]" | |||
|
|
|||
| # Check printing of more exotic objects | |||
| @test sprint(JSON.print, sprint) == string("\"function at ", sprint.fptr, "\"") | |||
| # Test broken in v0.5, code is using internal structure of Function type! | |||
| #@test sprint(JSON.print, sprint) == string("\"function at ", sprint.fptr, "\"") | |||
There was a problem hiding this comment.
if this can't be adjusted in a more general way, then it should probably at least be conditional on the version where the change was merged
There was a problem hiding this comment.
How can I track down the version string for that? I know the commit number: 9bfd27bd380124174a5f37c342e5c048874d71a4, but I don't know how to go from there to:
if VERSION < v"0.5.0-dev+1343". As far as adjusting it in a general way, Jeff has said it shouldn't even be trying to print out the function pointer for JSON.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you, that was perfect, v"0.5.0-dev+2396"
Update tests, check if no parameter for key set Work around bug using .fptr from Function structure Don't use keytype, which is broken in v0.4.3 Base code and test off of version string of PR 13412
|
It seems there is another bug, on v0.4 and v0.3, the |
|
What do you mean by "it doesn't work correctly"? Could you provide an example? |
|
Sorry for not being complete (the train I was waiting for arrived!). keytype (and valtype) were added in v0.4 (I thought I saw somewhere that it was in v0.3, but I was wrong), however it only has one definition, julia> methods(keytype)
# 1 method for generic function "keytype":
keytype{K,V}(::Associative{K,V}) at dict.jl:219and gets an error if you try to pass in the type, which works in v0.5: julia> keytype(Dict{Int,Any})
ERROR: MethodError: `keytype` has no method matching keytype(::Type{Dict{Int64,Any}})(In v0.5:) julia> keytype(Dict{AbstractString,Any})
AbstractString
keytype{K,V}(::Type{Associative{K,V}}) at dict.jl:228
keytype(a::Associative{K<:Any,V<:Any}) at dict.jl:229
keytype{A<:Associative{K,V}}(::Type{A}) at dict.jl:230 |
|
@kmsquire @nalimilan This is now passing all its tests in v0.3.x, v0.4.3, and master. Anything else? Thanks! |
|
@kmsquire, @nalimilan, @tkelman Can this one be merged or are there further changes necessary? |
|
@kmsquire , @nalimilan , @tkelman |
No description provided.