use full type path in type resolution #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this should probably also check that everything but the last component names a module. |
|
This looks good to me. CI is passing. It would be good to have a regression test. |
DilumAluthge
approved these changes
Jan 3, 2020
|
I've gone ahead and bumped the version number so that we can tag a new release as soon as we merge this PR. |
JeffBezanson
force-pushed
the
jb/typepaths
branch
from
013fdbc to
64a4216
Compare
|
Ok should be set now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a non-deterministic bug is possible if two different modules have a type with the same name.
_resolve_typedrops the first path component (the top-level module) and instead searches all modules in hash order. This fixes it by just using the whole path. I believe this was introduced by 9ef1e09. If this looks good I'll add a test.