-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow manually specifying DPI #214
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 73.93% // Head: 66.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 73.93% 66.96% -6.97%
==========================================
Files 3 3
Lines 422 442 +20
==========================================
- Hits 312 296 -16
- Misses 110 146 +36
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
LGTM, thanks! No strong feelings about a test file, other than it should be reasonably small and with unproblematic license. Wikimedia has a few, this one seems appropriate: https://commons.wikimedia.org/wiki/File:FLAT_-_What_is_Creative_Commons.pdf |
should also fix JuliaIO#158
PDFs are currently always read with the default DPI of 70, which is not particularly high. This allows manually specifying it using the `dpi` keyword. Still needs a test, is there a good sample PDF document I could use for this? cc @timholy
PDFs are currently always read with the default DPI of 72, which is not
particularly high. This allows manually specifying it using the
dpi
keyword. Still needs a test, is there a good sample PDF document I could
use for this?
cc @timholy