Add formatting check action and apply an initial format

.JuliaFormatter.toml

@@ -0,0 +1,10 @@
+style = "blue"
+annotate_untyped_fields_with_any = false
+short_to_long_function_def = false
+trailing_comma = "nothing"
+always_use_return = false
+import_to_using = false
+align_struct_field = true
+align_conditional = true
+align_assignment = true
+align_pair_arrow = true

.github/workflows/CI.yml

@@ -28,7 +28,7 @@ jobs:
           sudo apt-get install mpich libhdf5-mpich-dev
           echo "JULIA_HDF5_PATH=/usr/lib/x86_64-linux-gnu/hdf5/mpich/" >> $GITHUB_ENV
           echo "JULIA_MPI_BINARY=system" >> $GITHUB_ENV
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/setup-julia@latest
         with:
           version: ${{ matrix.version }}
@@ -68,7 +68,7 @@ jobs:
           - version: '1.3'
             os: windows-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/setup-julia@latest
         with:
           version: ${{ matrix.version }}
@@ -78,7 +78,7 @@ jobs:
         env:
           JULIA_DEBUG: Main
       - uses: julia-actions/julia-processcoverage@latest
-      - uses: codecov/codecov-action@v1
+      - uses: codecov/codecov-action@v3
         with:
           file: lcov.info
 
@@ -99,14 +99,14 @@ jobs:
           - {user: JuliaIO, repo: MAT.jl}
           - {user: JuliaIO, repo: JLD.jl}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/setup-julia@latest
         with:
           version: ${{ matrix.version }}
           arch: ${{ matrix.arch }}
       - uses: julia-actions/julia-buildpkg@latest
       - name: Clone ${{ matrix.package.repo }}
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
           path: downstream
@@ -131,7 +131,7 @@ jobs:
   docs:
       runs-on: ubuntu-latest
       steps:
-        - uses: actions/checkout@v2
+        - uses: actions/checkout@v3
         - uses: julia-actions/julia-buildpkg@latest
         - uses: julia-actions/julia-docdeploy@latest
           env:

.github/workflows/Format-check.yml

@@ -0,0 +1,39 @@
+name: format
+
+on:
+  push:
+    branches:
+      - 'master'
+      - 'release-'
+    tags: '*'
+  pull_request:
+
+jobs:
+  check:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        julia-version: ['1']
+        julia-arch: [x64]
+        os: [ubuntu-latest]
+    steps:
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: ${{ matrix.julia-version }}
+
+      - uses: actions/checkout@v3
+      - name: Install JuliaFormatter and format
+        run: |
+          julia -e 'using Pkg; Pkg.add(PackageSpec(name="JuliaFormatter"))'
+          julia -e 'using JuliaFormatter; format(["src", "test", "deps", "filters", "gen"], verbose=true)'
+      - name: Format check
+        run: |
+          julia -e '
+          out = Cmd(`git diff --name-only`) |> read |> String
+          if out == ""
+              exit(0)
+          else
+              @error "Some files have not been formatted !!!"
+              write(stdout, out)
+              exit(1)
+          end'

deps/build.jl

@@ -2,14 +2,13 @@ using Libdl
 
 const depsfile = joinpath(@__DIR__, "deps.jl")
 
-libpath = get(ENV, "JULIA_HDF5_PATH",
-                get(ENV, "JULIA_HDF5_LIBRARY_PATH", nothing)) # legacy env variable for compatibility
+libpath = get(ENV, "JULIA_HDF5_PATH", get(ENV, "JULIA_HDF5_LIBRARY_PATH", nothing)) # legacy env variable for compatibility
 
 # We avoid calling Libdl.find_library to avoid possible segfault when calling
 # dlclose (#929).
 # The only difference with Libdl.find_library is that we allow custom dlopen
 # flags via the `flags` argument.
-function find_library_alt(libnames, extrapaths=String[]; flags = RTLD_LAZY)
+function find_library_alt(libnames, extrapaths=String[]; flags=RTLD_LAZY)
     for lib in libnames
         for path in extrapaths
             l = joinpath(path, lib)
@@ -44,8 +43,8 @@ else
     libpaths = [libpath, joinpath(libpath, "lib"), joinpath(libpath, "lib64")]
     flags = RTLD_LAZY | RTLD_NODELETE  # RTLD_NODELETE may be needed to avoid segfault (#929)
 
-    libhdf5 = find_library_alt(["libhdf5"], libpaths; flags = flags)
-    libhdf5_hl = find_library_alt(["libhdf5_hl"], libpaths; flags = flags)
+    libhdf5 = find_library_alt(["libhdf5"], libpaths; flags=flags)
+    libhdf5_hl = find_library_alt(["libhdf5_hl"], libpaths; flags=flags)
 
     isempty(libhdf5) && error("libhdf5 could not be found")
     isempty(libhdf5_hl) && error("libhdf5_hl could not be found")