Add filter keyword argument to create_dataset
#840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `create_dataset` to create a dataset with a user-defined
filter by setting the `filter` keyword to a Tuple of integers that
describe and configure the filter. For example, to use a filter
specified by `filter_id=32013`, `flags=0`, `cd_nelmts=3`, and
`cd_values=(2,0,8)`:
ds, dt = create_dataset(h5, "data", data,
chunk=(256,1,256),
filter=(32013,0,2,0,8))
Note that `cd_nelmts` is not included explicitly. It is inferred from
the length of the Tuple.
This is useful for user-defined filters.
The `filter` keyword argument now accepts `Tuple{Tuple{<:Integer}}` to
enable multiple user-defined filters when creating a dataset. Passing
`Tuple{<:Integer}` for a single user-defined filter is still supported.
musm
reviewed
Jun 15, 2021
musm
reviewed
Jun 15, 2021
musm
approved these changes
Jun 15, 2021
|
Looks like there's some issue with CI (might need to rebase on top of master), but otherwise LGTM. |
|
will merge in 24 hours sans objections |
Better names are better! :)
|
I just pushed the suggested changes (though not via the GitHub interface). As the commit log message says, better names are better. Thanks! |
|
Any clue on the https://github.com/JuliaIO/HDF5.jl/pull/840/checks?check_run_id=2826317219 failure, it might be real? |
|
Looks like it's a convert error although I'm not sure why it's isolated to julia 1.3 |
musm
reviewed
Jun 15, 2021
This new way actually allocates fewer bytes and is compatible with Julia 1.3.
musm
reviewed
Jun 15, 2021
|
Thanks for your great detective work @musm! |
Closed
musm
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Add `filter` keyword argument to create_dataset
This allows `create_dataset` to create a dataset with a user-defined
filter by setting the `filter` keyword to a Tuple of integers that
describe and configure the filter. For example, to use a filter
specified by `filter_id=32013`, `flags=0`, `cd_nelmts=3`, and
`cd_values=(2,0,8)`:
ds, dt = create_dataset(h5, "data", data,
chunk=(256,1,256),
filter=(32013,0,2,0,8))
Note that `cd_nelmts` is not included explicitly. It is inferred from
the length of the Tuple.
* Add H5Z_FLAG_MANDATORY constant
This is useful for user-defined filters.
* Support multiple user-defined filters per dataset
The `filter` keyword argument now accepts `Tuple{Tuple{<:Integer}}` to
enable multiple user-defined filters when creating a dataset. Passing
`Tuple{<:Integer}` for a single user-defined filter is still supported.
* Add tests for filter keyword arg of create_dataset
* Change some type/names based on code review
Better names are better! :)
* Change how `set_filter` passes Tuple as Ptr{Cuint}
This new way actually allocates fewer bytes and is compatible with
Julia 1.3.
* Add comment about passing cd_values in set_filter
(cherry picked from commit 834141a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
create_datasetto create a dataset with a user-definedfilter by setting the
filterkeyword to a Tuple of integers thatdescribe and configure the filter. For example, to use a filter
specified by
filter_id=32013,flags=0,cd_nelmts=3, andcd_values=(2,0,8):Note that
cd_nelmtsis not included explicitly. It is inferred fromthe length of the Tuple.