Add row/column-major order documentation #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
Jan 14, 2021
musm
reviewed
Jan 14, 2021
qin-yu
force-pushed
the
qy/fix785-doc-order
branch
from
e366e66
to
88a64e2
Compare
|
I just noticed there is another PR with a page of details! Somehow the GitHub homepage doesn't update if a PR refers to our issue, so I didn't notice. I believe the issue itself combines with #804 is more than enough to provide some essential information on this. Any comment on the new version? @musm If you think it's bad or you don't want merge both PR, I wouldn't mind if you close this PR in favor of the other one. |
musm
reviewed
Jan 15, 2021
musm
reviewed
Jan 15, 2021
Co-authored-by: Mustafa M <[email protected]>
musm
approved these changes
Jan 17, 2021
Co-authored-by: Mustafa M <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to fix #785
Add short descriptions in README and documentation to warn users about the two methods for storing multidimensional arrays.