Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax libhdf version and update CI to test system libhdf5 #781

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

musm
Copy link
Member

@musm musm commented Dec 15, 2020

Summary of changes:

  • Relax libhdf5 to v1.10.4 (this is the version shipped with ubuntu-lts)
  • Merge all CI into one file (easier to maintain and update)
  • Test libhdf5 + mpio integration on CI

@musm
Copy link
Member Author

musm commented Dec 15, 2020

@jipolanco I'm running into

Attempting to use an MPI routine before initializing MPICH
HDF5: infinite loop closing library
      L,T_top,P,P,Z,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD

when I run the test with with MPI. This is on my system with:

sudo apt install libhdf5-mpich-dev
export JULIA_HDF5_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/hdf5/mpich/

Any chance you would know why we are running into this?

In particular it looks like this method is triggering the error

    HDF5.h5p_set_fapl_mpio(fileprop, comm, info)

in the mpio.jl test suite.

version:
- '1.3'
os:
- ubuntu-20.04
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to ubuntu-latest when gh-actions get's updated (required for libhdf5 v1.10.4)

@jipolanco
Copy link
Contributor

@jipolanco I'm running into

Attempting to use an MPI routine before initializing MPICH
HDF5: infinite loop closing library
      L,T_top,P,P,Z,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD,FD

when I run the test with with MPI. This is on my system with:

sudo apt install libhdf5-mpich-dev
export JULIA_HDF5_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu/hdf5/mpich/

Any chance you would know why we are running into this?

In particular it looks like this method is triggering the error

    HDF5.h5p_set_fapl_mpio(fileprop, comm, info)

in the mpio.jl test suite.

@musm I'm not sure, but it may be because you're not using your system's MPICH. For this, you should set the environment variable JULIA_MPI_BINARY=system and then rebuild MPI.jl and HDF5.jl.

You may also be interested in this github CI setup using MPI and HDF5 on Ubuntu.

@musm
Copy link
Member Author

musm commented Dec 16, 2020

That was very helpful, many thanks @jipolanco

@musm musm changed the title Relax libhdf version requirement Relax libhdf version requirement and update CI to test system libhdf5 Dec 16, 2020
@jipolanco
Copy link
Contributor

No problem. Thanks for the extra tests and for relaxing the libhdf5 requirement!

@musm musm force-pushed the libver branch 6 times, most recently from f29bf1e to 1af86b4 Compare December 16, 2020 07:42
Relax the minimum libhdf5 library requirement and also add CI testing using system provided libhdf5 libraries
@musm musm changed the title Relax libhdf version requirement and update CI to test system libhdf5 Relax libhdf version and update CI to test system libhdf5 Dec 16, 2020
@musm musm force-pushed the libver branch 8 times, most recently from 40debd9 to 94c2315 Compare December 16, 2020 17:53
…ries

First, update the build instructions and promote the new
`JULIA_HDF5_PATH` env variable which will look for the shared libhdf5
libraries in the lib folder by default.

Also, update CI to test MPI using system libraries
@musm musm merged commit dbe7a99 into JuliaIO:master Dec 16, 2020
@musm musm deleted the libver branch December 16, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants