Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ishdf5 error handling and improve general error silencing #780

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Fix ishdf5 error handling and improve general error silencing #780

merged 2 commits into from
Dec 15, 2020

Commits on Dec 14, 2020

  1. Fix ishdf5 error handling and improve general error silencing 

    The docs state that h5f_is_hdf5 does not error throw, but that is not true.
We first suppress the hdf5 libraries stack trace printing, and then fix
the return to ensure false condition is thrown when the file is not
accessible in the hdf5 format.

We have also renamed the hiding_errors method and ensured that the final
stacktrace reset is guaranteed in case the underlying function call
throws an error.
    @musm
    musm committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    96cbe2e View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Address review comments

    @musm
    musm authored Dec 15, 2020
    Configuration menu
    Copy the full SHA
    c824094 View commit details
    Browse the repository at this point in the history