Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for KeyError #778

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Fix error message for KeyError #778

merged 3 commits into from
Dec 11, 2020

Conversation

musm
Copy link
Member

@musm musm commented Dec 11, 2020

No description provided.

@jmert
Copy link
Contributor

jmert commented Dec 11, 2020 •
edited
Loading

I think my intention was throwing the tuple of values; apparently I missed a set of parentheses.

julia> KeyError((1, 2, 3))
KeyError((1, 2, 3))

That'd avoid the string interpolation machinery that otherwise has to get inlined into the function as well.

@musm musm merged commit 133e7fb into JuliaIO:master Dec 11, 2020
@musm musm deleted the errorfix branch December 11, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmert jmert jmert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@musm @jmert