Delete straggling create_dataset method #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
commented
Dec 10, 2020
jmert
reviewed
Dec 11, 2020
Co-authored-by: jmert <[email protected]>
|
Yep. Also if you run julia with depwarn set to true you will get the depreciation warnings printed, which will make upgrading trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we really need a deprecation for this, but looks like it accidentally snuck in v0.14.
EDIT: yes we do, looks like JLD is using this. (Finally good use of the integration testing)
Altough the failure there is mem map failure not anything related to the deprecation AFAIK.