-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap more of the HDF5 API with generated bindings #677
Conversation
LGTM and a good clean up, just some minor comments! |
I added a second commit that moves the definition of It's a bit ugly, but that should maybe just be taken as motivation to work on sorting out the initialization process. |
Hmmm... MacOS nightly failed in both Travis and Github Actions, apparently with |
Strange, let's drop that commit for now so we can get the rest of the changes in? |
I've backed off this branch by one commit. Let's see if MacOS CI is still unhappy or not. Edit: Still fails. Looking at other commits to master, though, and I'm finding that MacOS nightly was already failing there, too — https://github.com/JuliaIO/HDF5.jl/runs/1137069384 — so it's not an interaction with this PR specifically. |
Something needs to be fixed in HDF5_jll — I made a branch that just prints a bunch from |
Thanks for detecting this bug. Let's see if we can get that fixed. So I guess this PR discovered a bug in the HDF_jll wrapper which is good. |
osx on master should now be fixed |
want to try that second commit now? |
This wraps more direct uses of
ccall
s with bindings made with the generator.There are a few notable exceptions due to either (a) memory handling which the binding generator cannot (yet?) deal with, and (b) a case where a call to the underlying
H5Dwrite
is relying on being able to declare the buffer to typeCstring
for its data validation features.One more interesting change is to the
h5t_get_member_name
andh5t_get_tag
functions — this changes to usingh5_free_memory
fromLibc.free
as noted in theh5t_get_member_name
documentation (which says it's more important on Windows).