add support for CartesianRange indexing #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
reviewed
Nov 28, 2017
| function setindex!{N}(dset::HDF5Dataset, val, cr::CartesianRange{CartesianIndex{N}}) | ||
| # transfer to unit range | ||
| ur = map((x,y)->x:y, cr.start.I, cr.stop.I) | ||
| @show ur |
|
This functionality seems useful although I am not so sure that the implementation is optimal. I wonder if anyone else has any comments |
timholy
approved these changes
Nov 28, 2017
| @@ -710,6 +710,12 @@ function h5read(filename, name::String, indices::Tuple{Vararg{Union{Range{Int},I | |||
| dat | |||
| end | |||
|
|
|||
| function h5read{N}(filename, name::String, cr::CartesianRange{CartesianIndex{N}}) | |||
| # transfer to unit range | |||
| ur = map((x,y)->x:y, cr.start.I, cr.stop.I) | |||
There was a problem hiding this comment.
Better to use first(cr) and last(cr) than cr.start.I and cr.stop.I; in 0.7, the representation of CartesianRange has changed. Indeed, in 0.7 this can just be ur = cr.indices.
ggggggggg
suggested changes
Nov 30, 2017
| dset = f["main"] | ||
| # setindex of cartesian range | ||
| dset[CartesianRange((3:5,))] = [4:6;] | ||
| @test dset[CartesianRange((3:5,))] == [4:6;] |
There was a problem hiding this comment.
The tests should cover a case with more than one dimension. Also, why is the correct answer not [3:5;] as you would get with a normal range?
There was a problem hiding this comment.
because on line 14 he rewrites elements 3:5 to 4:6 (which is testing setindex!)
|
addressed review in #459 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CartesianRange is widely used to handle ranges, adding support of CartesianRange to index the arrays inside dataset could make some implementation easier.
These functions were moved from BigArrays.jl
seung-lab/BigArrays.jl#21