Fix macro hygiene bug in test files and deprecated string method and … #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musm
commented
Jan 13, 2017
| @@ -2145,19 +2145,19 @@ function h5a_get_name(attr_id::Hid) | |||
| len = h5a_get_name(attr_id, 0, C_NULL) # order of args differs from {f,i}_get_name | |||
| buf = Array(UInt8, len+1) | |||
| h5a_get_name(attr_id, len+1, buf) | |||
| @compat unsafe_string(buf[1:len]) | |||
There was a problem hiding this comment.
doesn't make sense to unsafe_string an UInt8 array, we want the name
musm
commented
Jan 13, 2017
| @@ -1383,7 +1383,7 @@ end | |||
| # Read compound type | |||
| @compat function read(obj::HDF5Dataset, ::Union{Type{Array{HDF5Compound}},Type{HDF5Compound}}) | |||
| t = datatype(obj) | |||
| local sz = 0, n, membername, membertype, memberoffset, memberfiletype | |||
There was a problem hiding this comment.
this kind of variable definition is deprecated in 0.6
|
OS X nightly hdf5 has build errors with homebrew. I believe these are unrelated to the PR. |
|
closing in favor of #354 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…other bugfix
tests pass locally on 0.4 0.5 and nightly