Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience function set_libraries! #1115

Merged
merged 13 commits into from
Sep 24, 2023

Conversation

JoshuaLampert
Copy link
Contributor

This adds a function set_libraries! to conveniently set the preferences for a custom HDF5 library.

closes #1114

@JoshuaLampert
Copy link
Contributor Author

Do we (alternatively? additionally?) want to allow the user to pass one path to a directory, where both libraries are located?

@JoshuaLampert
Copy link
Contributor Author

How can I set the docstring without the documenter complaining?

@mkitti
Copy link
Member

mkitti commented Sep 10, 2023

You should add set_libraries! to the list of documented functions.

@JoshuaLampert
Copy link
Contributor Author

Thanks @mkitti! I also removed not_low_level_api, which appears to be unused and was quite confusing to me.

@mkitti
Copy link
Member

mkitti commented Sep 10, 2023

Do we (alternatively? additionally?) want to allow the user to pass one path to a directory, where both libraries are located?

I'm still thinking about this. It seems to mainly add complexity

@mkitti mkitti merged commit 625555b into JuliaIO:master Sep 24, 2023
15 of 16 checks passed
@JoshuaLampert JoshuaLampert deleted the set-libraries branch September 24, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convenience function to use custom or system provided HDF5 binaries
2 participants