Move code to highlevel.jl #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mkitti
commented
Aug 6, 2022
•
mkitti
commented
- Moves high-level interface and property manipulation to highlevel.jl
musm
reviewed
Aug 6, 2022
src/propertymanipulation.jl
Outdated
| @@ -0,0 +1,7 @@ | |||
| ### Property manipulation ### | |||
There was a problem hiding this comment.
Can't these live in the highlevel file? I don't think it's helpful to have these in a separate file.
mkitti
changed the title
musm
reviewed
Aug 8, 2022
| write(parent, path, val; pv...) | ||
| end | ||
|
|
||
| ### Property manipulation ### |
There was a problem hiding this comment.
On second thought why not at the end of https://github.com/JuliaIO/HDF5.jl/blob/master/src/properties.jl ? Seems more appropriate especially since that's where the *Properties types are defined?
There was a problem hiding this comment.
I tried that. It does not work. We would need to move the property types up into types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.