Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileIO integration #278

Closed
SimonDanisch opened this issue Dec 9, 2015 · 5 comments · Fixed by #782
Closed

FileIO integration #278

SimonDanisch opened this issue Dec 9, 2015 · 5 comments · Fixed by #782

Comments

@SimonDanisch
Copy link
Member

I see that the file format is registered in FileIO in https://github.com/JuliaIO/FileIO.jl/blob/master/src/registry.jl#L106
But it seems like there is no load function defined for it in HDF5 itself (JuliaGL/GLVisualize.jl#44).
Is there a reason for that?

Best,
Simon

@timholy
Copy link
Member

timholy commented Dec 9, 2015

No reason other than it hasn't been added.

I think the JLD one is also importing load and save, and with the redesign it shouldn't be.

@SimonDanisch
Copy link
Member Author

Good to know! Well then, I might create a PR if If I find the time.

@ggggggggg
Copy link
Contributor

What should these do? load seems straightforward, just return an HDF5File. save is less, say it is passed an array, what should it call the dataset that it writes to? What happens if you call save again, write to a new dataset? Is save(fname,data) supposed to be able to be followed by load(fname)==data being true?

@jonas-schulze
Copy link

Are there any updates on this?

I was trying out DrWatson.jl and saving any .hdf5 file fails with

Error encountered while saving "/Users/jonas/Research/FooProject/data/sim/prefix_N=50.hdf5".
Fatal error:
ERROR: LoadError: UndefVarError: save not defined

@musm
Copy link
Member

musm commented Nov 6, 2020

Doesn't this work? (I haven't tried it) Looking at https://github.com/JuliaIO/FileIO.jl/blob/master/src/registry.jl#L303 it seems like it's in the registry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants