Skip to content

Commit

Permalink
more missing docs
Browse files Browse the repository at this point in the history
  • Loading branch information
simonbyrne committed Jan 23, 2023
1 parent 4d67028 commit 6b86455
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 11 deletions.
2 changes: 2 additions & 0 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ makedocs(;
pages=[
"Home" => "index.md",
"Interface" => [
"interface/configuration.md",
"interface/files.md",
"interface/groups.md",
"interface/dataspaces.md",
"interface/dataset.md",
Expand Down
2 changes: 2 additions & 0 deletions docs/src/api_bindings.md
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,7 @@ h5l_move
- [`h5o_get_comment`](@ref h5o_get_comment)
- [`h5o_get_comment_by_name`](@ref h5o_get_comment_by_name)
- [`h5o_get_info`](@ref h5o_get_info)
- [`h5o_get_info1`](@ref h5o_get_info1)
- [`h5o_get_info_by_idx`](@ref h5o_get_info_by_idx)
- [`h5o_get_info_by_name`](@ref h5o_get_info_by_name)
- [`h5o_get_native_info`](@ref h5o_get_native_info)
Expand Down Expand Up @@ -374,6 +375,7 @@ h5o_flush
h5o_get_comment
h5o_get_comment_by_name
h5o_get_info
h5o_get_info1
h5o_get_info_by_idx
h5o_get_info_by_name
h5o_get_native_info
Expand Down
5 changes: 5 additions & 0 deletions docs/src/interface/filters.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,13 @@ The filter interface is used to describe filters and obtain information on them.
```@docs
Filter
FilterPipeline
UnknownFilter
FILTERS
EXTERNAL_FILTER_JULIA_PACKAGES
filterid
isavailable
isdecoderenabled
isencoderenabled
encoder_present
decoder_present
filtername
Expand Down
4 changes: 4 additions & 0 deletions gen/gen_wrappers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ Base.remove_linenums!(exprs)

# Definitions which are not automatically generated, but should still be documented as
# part of the raw low-level API:
append!(bound_api["H5O"], [
# defined in src/api/helpers.jl
"h5o_get_info1",
])
append!(bound_api["H5P"], [
# defined in src/api/helpers.jl
"h5p_get_class_name",
Expand Down
8 changes: 1 addition & 7 deletions src/api/helpers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -548,13 +548,7 @@ Deprecated HDF5 function. Use [`h5o_get_info`](@ref) or [`h5o_get_native_info`](
See `libhdf5` documentation for [`H5Oget_info1`](https://portal.hdfgroup.org/display/HDF5/H5O_GET_INFO1).
"""
function h5o_get_info1(object_id, buf)
var"#status#" = ccall(
(:H5Oget_info1, libhdf5), herr_t, (hid_t, Ptr{H5O_info_t}), object_id, buf
)
var"#status#" < 0 && @h5error("Error getting object info")
return nothing
end
h5o_get_info1(object_id, buf) = h5o_get_info()
function h5o_get_info1(loc_id)
oinfo = Ref{H5O_info1_t}()
h5o_get_info1(loc_id, oinfo)
Expand Down
9 changes: 5 additions & 4 deletions src/drivers/mpio.jl
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using .MPI
import Libdl
import HDF5: h5open

###
### MPIO
Expand Down Expand Up @@ -96,15 +97,15 @@ support.
See the [HDF5 docs](https://portal.hdfgroup.org/display/HDF5/H5P_SET_FAPL_MPIO)
for details on the `comm` and `info` arguments.
"""
function HDF5.h5open(
function h5open(
filename::AbstractString,
mode::AbstractString,
comm::MPI.Comm,
info::MPI.Info=MPI.Info();
pv...
)
HDF5.h5open(filename, mode; driver=MPIO(comm, info), pv...)
h5open(filename, mode; driver=MPIO(comm, info), pv...)
end

HDF5.h5open(filename::AbstractString, comm::MPI.Comm, args...; pv...) =
HDF5.h5open(filename, "r", comm, args...; pv...)
h5open(filename::AbstractString, comm::MPI.Comm, args...; pv...) =
h5open(filename, "r", comm, args...; pv...)

0 comments on commit 6b86455

Please sign in to comment.