Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerance options to SemialgebraicSets solver #488

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Add tolerance options to SemialgebraicSets solver #488

merged 2 commits into from
Sep 8, 2021

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Sep 6, 2021

Supersedes #483

@blegat blegat mentioned this pull request Sep 6, 2021
Closed
@blegat
Copy link
Contributor Author

blegat commented Sep 8, 2021

The test failures https://github.com/JuliaHomotopyContinuation/HomotopyContinuation.jl/pull/488/checks?check_run_id=3543229372#step:5:1604 seem unrelated.

@saschatimme
Copy link
Member

Looks good :) I would be curious whether this works well for larger example since these tolerance in excess solutions are in general very tricky to handle.

@saschatimme saschatimme merged commit 35967b8 into JuliaHomotopyContinuation:master Sep 8, 2021
@PBrdng
Copy link
Collaborator

PBrdng commented Sep 9, 2021

Thank you @blegat

@blegat blegat mentioned this pull request Sep 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschatimme saschatimme saschatimme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blegat @saschatimme @PBrdng