Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote parametric type in IComplex constructor. #486

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Promote parametric type in IComplex constructor. #486

merged 2 commits into from
Sep 2, 2021

Conversation

LauraBMo
Copy link
Contributor

@LauraBMo LauraBMo commented Sep 1, 2021

Working with polynomials with big coefficients I had an "ERROR: MethodError:..." for the IComplex constructor.
This PR solved the problem.
An MWE to reproduce the error:

const HCIA = HomotopyContinuation.IntervalArithmetic
HCIA.IComplex(HCIA.Interval(1, big(2)), HCIA.Interval(0,1))

Interval constructor handles the type promotion in line 30, but for IComplex is missing. This PR aims to add it.

@PBrdng
Copy link
Collaborator

PBrdng commented Sep 2, 2021

Hi, this looks like a nice bug fix. Thank you!

@saschatimme saschatimme merged commit ee96e6b into JuliaHomotopyContinuation:master Sep 2, 2021
@LauraBMo LauraBMo deleted the IComplex-promote-param-type branch September 2, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants