Monodromy with predefined tolerance for unique points #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBrdng
changed the title
saschatimme
approved these changes
Jun 28, 2021
saschatimme
deleted the
monodromy-with-predefined-tolerance-for-unique_points
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to pass tolerance options to
unique_pointsthrough themonodromy_solvefunction. The goal of this pull request is to change this.There is one thing up for discussion: currently,
monodromy_solveby default uses the functionuniqueness_rtolfor setting the relative tolerance. This is a different default than is used byunique_points. Should two functions have different defaults?